security: bound interactive binary choices to 1 or 2 - #249
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 111 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
현재 HEAD는 제목·본문과 달리 |
d288682 to
45d29dc
Compare
네, 지적하신 사항을 수정했습니다. PR 브랜치의 HEAD에서 |
Problem
Three interactive
readline()paths accepted any digit string with^[0-9]+$and then calledas.integer(). Inputs outside R's integer range can becomeNA_integer_; the downstream condition then aborts instead of treating the input as invalid.Change
1or2choices with^[12]$.interactive()andreadline()so testthat can replace base functions inside the locked package namespace without changing normal function lookup.local_mocked_bindings()is stable.Scope
Only
R/aFIPC.R, the deterministic test binding, test dependency floor, focused tests, and the Sentinel note are changed. Earlier unrelated.Rbuildignore, Bolt, and Palette churn was removed.Merge contract
Merge only after the exact current head passes R CMD check, code quality, security scans, central coverage evidence, all review threads, and independent review. No passing result is claimed before those checks finish.